DYN-8957 fix: set NoNetworkMode before InitializeComponent in WorkspaceDependencyView#17170
Closed
jasonstratton wants to merge 1 commit into
Closed
Conversation
…ncyView NoNetworkMode is a plain CLR property with no change notification. When assigned after InitializeComponent(), the XAML DataTrigger that drives IsEnabled on the Install button had already evaluated the binding with the default value (false) and would never re-fire. Moving the assignment before InitializeComponent() ensures the trigger reads the correct value on first evaluation and the button is reliably disabled in no-network mode. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8957
|
Contributor
Author
|
Changes applied directly to PR #17149 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoNetworkModeis a plain CLR property with noINotifyPropertyChanged. When it was assigned afterInitializeComponent(), the XAMLDataTrigger(which drivesIsEnabledon the Install Specified Version button) had already evaluated the binding with the default valuefalseand would never re-fire.InitializeComponent()so the trigger reads the correct value on first evaluation.Test plan
WhenNoNetworkModeThenWorkspaceReferencesInstallButtonIsDisabledpasses (verifiesDependencyView.NoNetworkModeis propagated)--NoNetworkMode, open a graph with missing packages, open Workspace References — Install Specified Version button should be disabled🤖 Generated with Claude Code